[FFmpeg-devel] [PATCH] Add programs to ffprobe

[Florent Tribouilloy]

On 07/19/2013 07:02 PM, Stefano Sabatini wrote:
> On date Friday 2013-07-19 15:24:50 +0200, Florent Tribouilloy encoded:
>> Option -show_programs for ffprobe will sort the output
>> +    print_int("start_time", program->start_time);
>> +    print_int("end_time", program->end_time);
>
> is this a pts or a time? It could be useful to give a representation
> of the time as well.
>
> Then this could be:
> start_time_pts
> start_time
> ...
>
> Unfortunately the field name "_time" for denoting a timestamp was
> poorly choosen.
>> +    print_int("pts_wrap_reference", program->pts_wrap_reference);
>> +    print_int("pts_wrap_behavior", program->pts_wrap_behavior);
>
> I have no idea what these are for, and I'm not sure they should be
> exposed.

http://ffmpeg.org/doxygen/trunk/avformat_8h_source.html
"
916  /*****************************************************************
917  * All fields below this line are not part of the public API. They
918  * may not be used outside of libavformat and can be changed and
919  * removed at will.
920  * New public fields should be added right above.
921  *****************************************************************
922  */
923  int64_t start_time;
924  int64_t end_time;
925
926  int64_t pts_wrap_reference; ///< reference dts for wrap detection
927  int pts_wrap_behavior; ///< behavior on wrap detection
"
So, I suppose I should not print them :)

> Looks pretty sane otherwise, while at it check that the fate ffprobe
> tests still pass (make fate-list | grep ffprobe), ask if you don't
> know how to update the references.
I will send the new patches, look at it (make fate) and tell you if I do 
not find the way to update.

Regards,
-- 
Florent Tribouilloy
Intern at Smartjog