[FFmpeg-devel] [PATCH] lavfi: add attribute_align_arg to all public entry points

Michael Niedermayer michaelni at gmx.at
Fri Jul 26 14:07:12 CEST 2013


On Fri, Jul 26, 2013 at 11:35:53AM +0200, Hendrik Leppkes wrote:
> Actually the first patch was incomplete, here is a second version
> which also fixes the deprecated compat API properly.

>  buffersink.c |   16 ++++++++--------
>  buffersrc.c  |   10 +++++-----
>  2 files changed, 13 insertions(+), 13 deletions(-)
> 12b63a8d818db93f4f413c7a6f8937533323817d  0001-lavfi-add-attribute_align_arg-to-all-public-entry-po.patch
> From c6a9a18828bd4d943562102f27464e29932d2885 Mon Sep 17 00:00:00 2001
> From: Hendrik Leppkes <h.leppkes at gmail.com>
> Date: Fri, 26 Jul 2013 10:31:05 +0200
> Subject: [PATCH] lavfi: add attribute_align_arg to all public entry points
> 
> Previously it was partly only added to central functions called
> internally, however if GCC would inline these into the public fuction, the
> alignment attribute would not take effect.
> 
> Instead, add it to all public entry points to avoid these problems.

patch applied

If i understand it correctly it would be a gcc bug workaound as gcc
is effectively ignoring the attribute for inlined functions.
It thus should be reported to the gcc developers too in case it has
not been yet.

Thanks

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Into a blind darkness they enter who follow after the Ignorance,
they as if into a greater darkness enter who devote themselves
to the Knowledge alone. -- Isha Upanishad
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20130726/f182f9a3/attachment.asc>


More information about the ffmpeg-devel mailing list