[FFmpeg-devel] [PATCH] ffmpeg: raise level for message printed in case of auto-select pixel format

Stefano Sabatini stefasab at gmail.com
Sun Jul 28 14:16:08 CEST 2013


On date Sunday 2013-07-28 01:18:46 +0000, Carl Eugen Hoyos encoded:
> Stefano Sabatini <stefasab <at> gmail.com> writes:
> 
> > On date Saturday 2013-07-27 16:53:38 +0000, 
> > Carl Eugen Hoyos encoded:
> > > Stefano Sabatini writes:
> > > 
> > > > -    av_log(NULL, AV_LOG_INFO,
> > > > +    av_log(NULL, AV_LOG_WARNING,
> > > >             "No pixel format specified, %s for 
> > > > H.264 encoding chosen.\n"
> > > 
> > > I don't think this is a good idea.
> > 
> > Why?
> 

> Because I don't think it is a good idea to raise 
> the level of an informational message to "warning"?

"Informational message" and "warning" are not clearly defined (a
warning is always an informational message), thus the use distinction
must be practical. "Warning" implies that the message contains some
information which affects the final outcome, a compatibility issue in
this case, while "informational" in my interpretation provides
information related to the program itself, and thus not immediately
relevant to the user.

Of course the distinction is blurry, but rather than discussing the
semantical connotations and dinstinctions between the two terms to
death, I suggest to raise the level for purely practical reasons, it
will avoid *massive* troubleshooting since it will be noticed by more
users, and thus will potentially save X man hours of debugging, for a
very small change.

> Or wasn't that what you mean?
> 
> > And why do you reply with a comment which implies 
> > another question?
> 
> Sorry, I don't understand this sentence.

Stating a claim not backed up by an explanation ("this is not a good
idea") is forcing me to ask for clarifications, this doesn't help to
make the thread as short as possible and tends to be frustrating for
the contributor.
-- 
FFmpeg = Fundamental and Fabulous Merciful Perennial Ephemeral Genius


More information about the ffmpeg-devel mailing list