[FFmpeg-devel] [PATCH] ffmpeg: raise level for message printed in case of auto-select pixel format

Hendrik Leppkes h.leppkes at gmail.com
Mon Jul 29 12:04:09 CEST 2013

On Mon, Jul 29, 2013 at 11:50 AM, Carl Eugen Hoyos <cehoyos at ag.or.at> wrote:
> Stefano Sabatini <stefasab <at> gmail.com> writes:
>> On date Monday 2013-07-29 09:36:06 +0000, Carl Eugen Hoyos encoded:
>> > Stefano Sabatini <stefasab <at> gmail.com> writes:
>> >
>> > > Will push the change in a day.
>> >
>> > You still haven't explained why raising the level
>> > of a purely informational message makes any sense.
>> I did it extensively and repeatedly in the past thread.
> While I can't really follow you with this message,
> please do not commit, this patch does no good.

Luckily, everyone is entitled to their own opinion.

I think the patch is useful, since it warns the user about an
assumption the code makes, which in quite a lot of cases may not be
what the user really wants.
To ensure the user sees this warning, it should also be marked as a
warning, or it might be missed, resulting in questions and/or
complaints later.

So IMHO, just go ahead and push.

- Hendrik

More information about the ffmpeg-devel mailing list