[FFmpeg-devel] [PATCH 5/5] libxvid: Reduce the size of an array

[Michael Niedermayer]

On Tue, Jul 30, 2013 at 07:42:32PM -0700, Timothy Gu wrote:
> It is not possible to have a plugin[] array with 5 or more elements.
> ---
> 
> Changed according to newer versions of other patches
> 
>  libavcodec/libxvid.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libavcodec/libxvid.c b/libavcodec/libxvid.c
> index edf5f43..8945c28 100644
> --- a/libavcodec/libxvid.c
> +++ b/libavcodec/libxvid.c
> @@ -364,7 +364,7 @@ static av_cold int xvid_encode_init(AVCodecContext *avctx)  {
>      xvid_plugin_ssim_t        ssim            = { 0 };
>      xvid_gbl_init_t           xvid_gbl_init   = { 0 };
>      xvid_enc_create_t         xvid_enc_create = { 0 };
> -    xvid_enc_plugin_t         plugins[7];
> +    xvid_enc_plugin_t         plugins[4];

the patch is correct but why should the array be tightened up ?
also it might make sense (independant of this patch) to check that
the array is large enough for the used plugins

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In fact, the RIAA has been known to suggest that students drop out
of college or go to community college in order to be able to afford
settlements. -- The RIAA
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20130731/07d8c860/attachment.asc>