[FFmpeg-devel] [PATCH] avformat/mov: compute dts_shift with trun cts

[Clément Bœsch]

On Mon, Jun 03, 2013 at 12:16:22PM +0200, Alexandre Sicard wrote:
> Le vendredi 31 mai 2013 17:32:37 Clément Bœsch a écrit :
> > 
> > Do you have a sample for this?
> > 
> 
> I have uploaded a sample on the FTP server, name is trun_negative_cts.ismv. It 
> was created by Microsoft Expression Encoder 4 Pro SP1.
> 
> > This reminds me various issues we had with random samples. Check for
> > instance:
> >   e74527219668b720aefb7ecb79a44a8137aafa60
> >   be401448e51f209a13e95d30f17d85d0168e1b40
> >   4093220029a4d77f272c491e9299680480a08c00
> > 
> > Such patch needs to be tested with the files mentioned in those
> > commits/associated tickets.
> 
> Patch was tested with these three files. I tried transmuxing and reencoding 
> them, with and without the patch, and got the exact same output files.
> 

Patch should be OK. The hack could be isolated in a function and shared
with the one in mov_read_ctts(), but I don't consider this blocking.

Another nitpick would be to use an intermediate duration variable to avoid
requesting 3 times sc->ctts_data[sc->ctts_count].duration, but that's not
really important as well.

I'll apply that patch in the next 24 hours unless someone object (or if I
forget).

[...]

-- 
Clément B.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 490 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20130606/975114d3/attachment.asc>