[FFmpeg-devel] [PATCH] drawbox: Respect thickness parameter
michaelni at gmx.at
Fri Jun 14 04:00:28 CEST 2013
On Thu, Jun 13, 2013 at 05:40:14PM +0300, Andrey Utkin wrote:
> 2013/6/12 Jean Delvare <khali at linux-fr.org>:
> > The drawbox video filter is drawing lines one pixel thinner than
> > requested. The default thickness is 4 pixel but in fact the lines
> > drawn by default are only 3 pixel wide.
> > Change the comparisons in the code to fix this off-by-one bug. Also
> > change the default thickness from 4 to 3 to minimize the unexpected
> > changes from the user's perspective.
> Interpreted ffmpeg code on the paper with pencil, original bug is
> reproduced, and the patch fixes it.
> > As I was already touching these lines, I also removed the "maximum" in
> > the thickness parameter description, as I don't think it was adding
> > any value and I even found it confusing.
> This could be considered a feature :) the thickness really does not
> exceed "maximum" value given by user :)
> I agree with changing the description line.
thanks to all
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
it is not once nor twice but times without number that the same ideas make
their appearance in the world. -- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 198 bytes
Desc: Digital signature
More information about the ffmpeg-devel