[FFmpeg-devel] [PATCH 1/3] ffplay: cast vp->height to int64 in buffer size check

Marton Balint cus at passwd.hu
Sat Jun 15 18:52:59 CEST 2013


Fixes Coverity CID 1026769 and 1026756.

Signed-off-by: Marton Balint <cus at passwd.hu>
---
 ffplay.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ffplay.c b/ffplay.c
index 26a813b..65b7cb0 100644
--- a/ffplay.c
+++ b/ffplay.c
@@ -1518,7 +1518,7 @@ static void alloc_picture(VideoState *is)
                                    SDL_YV12_OVERLAY,
                                    screen);
     bufferdiff = vp->bmp ? FFMAX(vp->bmp->pixels[0], vp->bmp->pixels[1]) - FFMIN(vp->bmp->pixels[0], vp->bmp->pixels[1]) : 0;
-    if (!vp->bmp || vp->bmp->pitches[0] < vp->width || bufferdiff < vp->height * vp->bmp->pitches[0]) {
+    if (!vp->bmp || vp->bmp->pitches[0] < vp->width || bufferdiff < (int64_t)vp->height * vp->bmp->pitches[0]) {
         /* SDL allocates a buffer smaller than requested if the video
          * overlay hardware is unable to support the requested size. */
         av_log(NULL, AV_LOG_FATAL,
-- 
1.8.1.4



More information about the ffmpeg-devel mailing list