[FFmpeg-devel] [PATCH] jpeg2000dec: make cblk->length(inc)/data use consistent
michaelni at gmx.at
Mon Jun 17 20:13:28 CEST 2013
On Mon, Jun 17, 2013 at 05:21:40PM +0200, Nicolas BERTRAND wrote:
> My previous comment is wrong.
> I forgot the case of several quality layers in image so the cblk
> length can change in case of a cblk dispatched in several layers.
> the image have 4 quality layers
> Is the +2 necessary in :
> if ( bytestream2_get_bytes_left(&s->g) < cblk->lengthinc
> + || sizeof(cblk->data) < cblk->length + cblk->lengthinc + 2
> To avoid a en empty read in the following bytestream2_get_bufferu?
the +2 is needed to prevent an out of array write from the 0xFF
> So, its LGTM
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
The worst form of inequality is to try to make unequal things equal.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 198 bytes
Desc: Digital signature
More information about the ffmpeg-devel