[FFmpeg-devel] [PATCH] Handling special characters in a URL.

Carl Eugen Hoyos cehoyos at ag.or.at
Fri Mar 1 19:24:56 CET 2013

Senthilnathan Maadasamy <senthilnathan.maadasamy <at> gmail.com> writes:

> The only case which is not correctly handled in the code is this:
component_size > MAX_URL_SIZE & length (percent encoded URL) > 
> MAX_URL_SIZE.  In this case the returned component buffer contains 
> only the partial encoded URL and not the complete one. 

> I think this case is very unlikely, 

> since most of the URL (percent encoded) should be of size < 4096. 
>  Let me know if I am missing something very basic.

You are missing that "very unlikely" isn't good enough 
for avoiding an out-of-array access / library crash.

Carl Eugen

More information about the ffmpeg-devel mailing list