[FFmpeg-devel] [PATCH]Avoid non-strict pointer aliasing in kega decoder
Reimar.Doeffinger at gmx.de
Mon Mar 4 08:29:52 CET 2013
On 4 Mar 2013, at 00:35, Carl Eugen Hoyos <cehoyos at ag.or.at> wrote:
> Thank you for the reviews!
> Attached patch fixes the fate failure for icc 13.1 (both 32 and 64 bit), using
> AV_COPY16() instead of memcpy shows the original problems.
Which would indicate the AV_COPY16 does not work with icc.
That is fairly worrying and might mean there will be more serious issues.
Apart from that, when I suggested memcpy I meant replacing the whole for loop by a single memcpy, no need to copy the pixels one by one.
Of course there is a bit of a question about which method is fastest but I guess it's not that critical for this codec.
More information about the ffmpeg-devel