[FFmpeg-devel] [PATCH]Fix memleak if decoder init fails

Michael Niedermayer michaelni at gmx.at
Fri Mar 8 01:03:22 CET 2013


On Thu, Mar 07, 2013 at 10:46:03PM +0000, Carl Eugen Hoyos wrote:
> Michael Niedermayer <michaelni <at> gmx.at> writes:
> 
> > > +                ost = output_streams[i];
> > > +                avcodec_close(ost->st->codec);
> > > +            }
> > >              goto dump_format;
> > > +        }
> > >  
> > 
> > can this affect dump_format ? 
> > that is does it access anything that might be freed here ?
> 
> Afaict, dump_format currently does neither use 
> output_streams->st nor output_streams->st->codec.

then the patch should be ok

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The real ebay dictionary, page 1
"Used only once"    - "Some unspecified defect prevented a second use"
"In good condition" - "Can be repaird by experienced expert"
"As is" - "You wouldnt want it even if you were payed for it, if you knew ..."
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20130308/2f078198/attachment.asc>


More information about the ffmpeg-devel mailing list