[FFmpeg-devel] [PATCH] lavfi/buffersink: implement av_buffersink_get_samples().
nicolas.george at normalesup.org
Sun Mar 10 19:53:14 CET 2013
Le decadi 20 ventôse, an CCXXI, Stefano Sabatini a écrit :
> What's the plan then? What's the new API we're supposed to adopt?
> av_buffersink_get_frame/samples(), or you plan to add new _flags()
> variants supporting our AVFilterBufferRef API API?
I am not sure what your question is. The AVFilterBufferRef stuff is
completely deprecated, as far as I can see, and the plan is to kill it in
favour of AVFrames.
But apart from AVFilterBufferRef->AVFrame, their API has not changed, and
neither should ours. Their main entry points are get_frame or get_samples,
depending on whether they need a fixed-size frame or not; our main entry
point is get_frame_flags, with set_frame_size for the fixed-size frame case.
Their API is supported, but not very optimized (a few mallocs/free in the
loop; reducing them would make more differences with their code).
> Most of this code is from libav. Mention the original author and
> please states the few differences in the commit log.
> Should be fine otherwise, thanks.
You are right. Fixed the commit and pushed. Thanks.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 198 bytes
Desc: Digital signature
More information about the ffmpeg-devel