[FFmpeg-devel] [PATCH 2/2] lavfi: add sine audio source.

Nicolas George nicolas.george at normalesup.org
Sun Mar 17 21:17:16 CET 2013

Le septidi 27 ventôse, an CCXXI, Stefano Sabatini a écrit :
> ... of the generated audio stream.

Locally added.

> doxy?
> doxy?

Locally added:

    uint32_t phi;  ///< current phase of the sine (2pi = 1<<32)
    uint32_t dphi; ///< phase increment between two samples

    uint32_t phi_beep;  ///< current phase of the beep
    uint32_t dphi_beep; ///< phase increment of the beep

> a bit overkill? But we may move the helpers to an internal header.

That is exactly the plan, provided it looks nice (it seems so to me for now)
and people like them.

> nit+++: sine_options[]_= {

Locally fixed.

I do not think sending another patch is required for these trivial changes.

Thanks for the review.


  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20130317/9f7eca3f/attachment.asc>

More information about the ffmpeg-devel mailing list