[FFmpeg-devel] [PATCH] lavfi/colormatrix: reword error message in init

Stefano Sabatini stefasab at gmail.com
Sun Mar 24 20:27:35 CET 2013


On date Sunday 2013-03-24 19:50:21 +0100, Clément Bœsch encoded:
> On Sun, Mar 24, 2013 at 01:48:32PM +0100, Stefano Sabatini wrote:
> > Change:
> > "source and destination color space are identical"
> > 
> > which is a true fact, but doesn't tell nothing about what's wrong, to:
> > "Source and destination color space must not be identical"
> > 
> > which tells more explicitly what's the problem.
> > ---
> >  libavfilter/vf_colormatrix.c |    2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/libavfilter/vf_colormatrix.c b/libavfilter/vf_colormatrix.c
> > index db0125d..2051abe 100644
> > --- a/libavfilter/vf_colormatrix.c
> > +++ b/libavfilter/vf_colormatrix.c
> > @@ -170,7 +170,7 @@ static av_cold int init(AVFilterContext *ctx, const char *args)
> >      }
> >  
> >      if (color->source == color->dest) {
> > -        av_log(ctx, AV_LOG_ERROR, "source and destination color space are identical\n");
> > +        av_log(ctx, AV_LOG_ERROR, "Source and destination color space must not be identical\n");
> >          return AVERROR(EINVAL);
> >      }
> 
> LGTM

Pushed.
-- 
FFmpeg = Friendly & Fucking Magic Portable Elected Glue


More information about the ffmpeg-devel mailing list