[FFmpeg-devel] [PATCH] biquad options

Paul B Mahol onemda at gmail.com
Thu Mar 28 13:01:12 CET 2013


On 3/28/13, ********* <signalratio at gmail.com> wrote:
> I found tiny mistake in af_biquads.c
> So, biquad options is not work.
>
> I modify INT16_MAX -> INT16_MIN.
> This change can be used biquad options.
>
> Thank you.
>
> af_biquads.c
>
>  #endif  /* CONFIG_ALLPASS_FILTER */
>  #if CONFIG_BIQUAD_FILTER
>  static const AVOption biquad_options[] = {
> -    {"a0", NULL, OFFSET(a0), AV_OPT_TYPE_DOUBLE, {.dbl=1}, INT16_MAX,
> INT16_MAX, FLAGS},
> -    {"a1", NULL, OFFSET(a1), AV_OPT_TYPE_DOUBLE, {.dbl=1}, INT16_MAX,
> INT16_MAX, FLAGS},
> -    {"a2", NULL, OFFSET(a2), AV_OPT_TYPE_DOUBLE, {.dbl=1}, INT16_MAX,
> INT16_MAX, FLAGS},
> -    {"b0", NULL, OFFSET(b0), AV_OPT_TYPE_DOUBLE, {.dbl=1}, INT16_MAX,
> INT16_MAX, FLAGS},
> -    {"b1", NULL, OFFSET(b1), AV_OPT_TYPE_DOUBLE, {.dbl=1}, INT16_MAX,
> INT16_MAX, FLAGS},
> -    {"b2", NULL, OFFSET(b2), AV_OPT_TYPE_DOUBLE, {.dbl=1}, INT16_MAX,
> INT16_MAX, FLAGS},
> +    {"a0", NULL, OFFSET(a0), AV_OPT_TYPE_DOUBLE, {.dbl=1}, INT16_MIN,
> INT16_MAX, FLAGS},
> +    {"a1", NULL, OFFSET(a1), AV_OPT_TYPE_DOUBLE, {.dbl=1}, INT16_MIN,
> INT16_MAX, FLAGS},
> +    {"a2", NULL, OFFSET(a2), AV_OPT_TYPE_DOUBLE, {.dbl=1}, INT16_MIN,
> INT16_MAX, FLAGS},
> +    {"b0", NULL, OFFSET(b0), AV_OPT_TYPE_DOUBLE, {.dbl=1}, INT16_MIN,
> INT16_MAX, FLAGS},
> +    {"b1", NULL, OFFSET(b1), AV_OPT_TYPE_DOUBLE, {.dbl=1}, INT16_MIN,
> INT16_MAX, FLAGS},
> +    {"b2", NULL, OFFSET(b2), AV_OPT_TYPE_DOUBLE, {.dbl=1}, INT16_MIN,
> INT16_MAX, FLAGS},

Thank you for reporting, fixed.


More information about the ffmpeg-devel mailing list