[FFmpeg-devel] [PATCH] lavfi: modify names of deshake_kernel.h and unsharp_kernel.h

Stefano Sabatini stefasab at gmail.com
Wed May 8 01:07:54 CEST 2013


On date Wednesday 2013-05-08 01:04:13 +0200, Clément Bœsch encoded:
> On Wed, May 08, 2013 at 12:56:34AM +0200, Stefano Sabatini wrote:
> [...]
> > > --- a/libavfilter/unsharp_kernel.h
> > > +++ b/libavfilter/unsharp_opencl_kernel.h
> > > @@ -134,4 +134,4 @@ kernel void unsharp(global  unsigned char *src,
> > >  
> > >  );
> > >  
> > > -#endif /* AVFILTER_UNSHARP_KERNEL_H */
> > > +#endif /* AVFILTER_UNSHARP_OPENCL_KERNEL_H */
> > 
> > same here.
> > 
> > LGTM otherwise, thanks.
> 
> Maybe it would be better to use a opencl_ prefix though (so files are
> sticked together)

Or alternatively put the files in a dedicated opencl dir (like we
basically do for ASM). But I consider per-filter grouping better than
per architecture grouping in this specific case, so I'd stick with
this patch approach.
-- 
FFmpeg = Fiendish & Fiendish Mean Picky Evanescent Gadget


More information about the ffmpeg-devel mailing list