[FFmpeg-devel] [PATCH] id3v2enc: chapter support

[Paul B Mahol]

On 5/10/13, Michael Niedermayer <michaelni at gmx.at> wrote:
> On Thu, May 09, 2013 at 04:26:49PM +0000, Paul B Mahol wrote:
>> Signed-off-by: Paul B Mahol <onemda at gmail.com>
>> ---
>>  libavformat/id3v2enc.c | 84
>> ++++++++++++++++++++++++++++++++++++++++++--------
>>  1 file changed, 71 insertions(+), 13 deletions(-)
>>

[...]

>
> char name[123] would be simpler, not needing the error check and free

I really do not see how that would by any simpler...

>
> rest LGTM if its tested with some software that supports reading
> this
>
> [...]
> --
> Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
>
> I know you won't believe me, but the highest form of Human Excellence is
> to question oneself and others. -- Socrates
>