[FFmpeg-devel] [PATCH 2/2] lavd/alsa: add stream validation

Nicolas George george at nsup.org
Fri Nov 1 14:18:13 CET 2013


Le primidi 11 brumaire, an CCXXII, Lukasz M a écrit :
> OK, you are right. By the others devices I meant video devices that in fact
> usually support only rawvideo.
> Audio devs supports more then I dropped last update and resend last patch
> to mailing list.

Yes, this is a strange discrepancy between autio and video: for video,
uncompressed video is covered by a single codec id, and the pixel format is
carried separately, while for audio there is a codec id per PCM format.

> From 11658a0edbfcfac5194707b18ec4a7cc573e1510 Mon Sep 17 00:00:00 2001
> From: Lukasz Marek <lukasz.m.luki at gmail.com>
> Date: Sat, 26 Oct 2013 01:32:55 +0200
> Subject: [PATCH 2/2] lavd/alsa: add stream validation
> 
> Don't trust provided streams.
> Return with error when stream count is not 1 or
> provided stream is not an audio stream.
> 
> Signed-off-by: Lukasz Marek <lukasz.m.luki at gmail.com>
> ---
>  libavdevice/alsa-audio-enc.c |    7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)

Still LGTM, thanks.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20131101/4070d7d9/attachment.asc>


More information about the ffmpeg-devel mailing list