[FFmpeg-devel] [PATCH 00/17] avutil: add Doxy groups and @file for crypto and hashing

Stefano Sabatini stefasab at gmail.com
Sun Nov 3 12:40:05 CET 2013


On date Saturday 2013-11-02 15:03:14 -0700, Timothy Gu encoded:
> Second batch.

Some general remarks.

@file and @brief are used inconsistenly.

My opinion is that we should remove @authors altogether. We have
already copyright and git log, and adding "authors" to FLOSS code,
while appealing to egos, is a bit offensive to future contributors and
complicates handling from the legal point of view (since you now have
another bit of authorship meta-information to keep into account).

@ingroup/@defgroup: we should decide how it is best to organize
groups, and if it makes sense to try to impose a necessarily arbitraty
hierarchy to the interface. My personal point of view is that we
should have a shallow categorization, mapping the headers organization
1-to-1.

Consistency: please use a common template. Also please discuss general
design before implementing long patchsets, this will save you time in
case of controversy and will help to define a shared consistent design
with other developers.
-- 
FFmpeg = Formidable & Fascinating Mystic Pitiful Evanescent Gnome


More information about the ffmpeg-devel mailing list