[FFmpeg-devel] [Bulk] [PATCH] avformat/mxfdec: dont truncate packets

[Tim Nicholson]

On 24/10/13 20:28, Michael Niedermayer wrote:
> Fixes Ticket2776
> 
> Signed-off-by: Michael Niedermayer <michaelni at gmx.at>
> ---
>  libavformat/mxfdec.c |    1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c
> index d0cbeea..59e5c0d 100644
> --- a/libavformat/mxfdec.c
> +++ b/libavformat/mxfdec.c
> @@ -2285,7 +2285,6 @@ static int mxf_read_packet_old(AVFormatContext *s, AVPacket *pkt)
>                                        "KLV for edit unit %i extending into "
>                                        "next edit unit",
>                                        mxf->current_edit_unit);
> -                klv.length = next_ofs - avio_tell(s->pb);
>              }
>  
>              /* check for 8 channels AES3 element */
> 

Sorry for a very late review, but I have been snowed under (with a
project using ffv1 v3 you may be pleased to hear) and after a quick
glance it didn't feel right and I wanted to delve further.

We go to the bother of performing a test to trap (an admittdedly
unusual) case, and then if it happens do not introduce the safety net to
avoid an error. It would be better to work out why a false positive is
occuring with the sample and fix that, otherwise we will reintroduce the
issue this segment of code was trying to fix.

Does Tomas have a view? the original code to trap the misreading of OP
Atom was his.

-- 
Tim