[FFmpeg-devel] [PATCH 2/2] avcodec/vdpau: try to fix version macro use

Michael Niedermayer michaelni at gmx.at
Tue Nov 5 23:56:49 CET 2013


On Tue, Nov 05, 2013 at 12:35:44PM +0100, Stefano Sabatini wrote:
> On date Tuesday 2013-11-05 12:03:48 +0100, Michael Niedermayer encoded:
> > Signed-off-by: Michael Niedermayer <michaelni at gmx.at>
> > ---
> >  libavcodec/vdpau.h |    8 +-------
> >  1 file changed, 1 insertion(+), 7 deletions(-)
> > 
> > diff --git a/libavcodec/vdpau.h b/libavcodec/vdpau.h
> > index b1c836c..97889ae 100644
> > --- a/libavcodec/vdpau.h
> > +++ b/libavcodec/vdpau.h
> > @@ -53,13 +53,7 @@
> >  #include <vdpau/vdpau_x11.h>
> >  #include "libavutil/avconfig.h"
> >  #include "libavutil/attributes.h"
> > -
> > -#ifndef FF_API_CAP_VDPAU
> > -#define FF_API_CAP_VDPAU 1
> > -#endif
> > -#ifndef FF_API_BUFS_VDPAU
> > -#define FF_API_BUFS_VDPAU 1
> > -#endif
> > +#include "version.h"
> 
> Makes sense but I cannot understand this (even if I guess it is
> related to the previous patch):

i guess the commit message below was based on a misunderstanding
of the problem or bug, iam not sure


> 
> commit 50fb8c1114b9c2b7d299cbc17a18a457d12069a8
> Author: Michael Niedermayer <michaelni at gmx.at>
> Date:   Tue Aug 6 14:03:40 2013 +0200
> 
>     avcodec/vdpau.h: define FF_API_CAP_VDPAU if its not defined
>     
>     Prevent build failure for applicatins using the old API
>     This could be replaced be a include of version.h but some applications
>     would then need extern C wrapers
>     
>     Signed-off-by: Michael Niedermayer <michaelni at gmx.at>
> -- 
> FFmpeg = Fancy Free Magical Practical Extravagant Gorilla
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Awnsering whenever a program halts or runs forever is
On a turing machine, in general impossible (turings halting problem).
On any real computer, always possible as a real computer has a finite number
of states N, and will either halt in less than N cycles or never halt.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20131105/e7a36260/attachment.asc>


More information about the ffmpeg-devel mailing list