[FFmpeg-devel] [PATCH] Add additional FFV1 fate tests

[Reimar Döffinger]

On Wed, Nov 06, 2013 at 10:24:23PM +0100, Peter B. wrote:
> On 11/06/2013 09:18 PM, Michael Niedermayer wrote:
> > On Wed, Nov 06, 2013 at 02:48:23PM +0100, Peter B. wrote:
> >> (libavcodec/ffv1enc.c):
> >> Lines 849-922: Looks like 2pass-related, but LCOV says it's not executed
> >> in my 2pass tests
> > the first question is, is the code really not executed
> > (the coverage stuff can give wrong results with optimizations)

On looking at it... It seems kind of unlikely to me that coverage
for exactly just this block would break.
Note that it will only be triggered by the 2nd pass of 2-pass.

> The 2nd-pass file is created without errors, so I'd *assume* it's
> executed but I don't know.

Just to be clear: this code is about reading in the 2pass file,
not writing it out,
Which gives another way to test: replace the numbers in the 2pass
logfile by some nonsense/letters, it should then trigger the
"2Pass file invalid" message in that code.