[FFmpeg-devel] [PATCH 0/2] Improved XSUB compatibility

Erik Olofsson eaj.olofsson at gmail.com
Thu Nov 7 11:37:03 CET 2013

2013/11/7 Reimar Döffinger <Reimar.Doeffinger at gmx.de>

> On 06.11.2013, at 21:22, Erik Olofsson <eaj.olofsson at gmail.com> wrote:
> > Fixes ticket3031
> Please put that in the commit messages, too.
Well, the first patch fixes the actual bug (garbeled playback) and the
second patch fixes what
the bug submitter reported (wrong number of bits per pixel).
The second patch does not seem to be needed, at least not in the two DVD
players I tested.

I wasn't sure how to attribute patches to fixes so I tried to attribute the
whole patchset to the ticket.
What about the following additions to the commit messages?
Fixes actual problem in ticket 3031
Fixes reported but not actual problem in ticket 3031

What does out xsub decoder do with the bounding box? Those two definitely
> should match.
> If the decoder already does +1 the patches look good, otherwise this needs
> one more look.

The coordinates of the lower right corner of the bounding box are actually
redundant as the
position and size of the text area are known.
Most decoders, including FFMpeg, ignores this redundant information.
Some hardware decoders do need them though.
This also matches other encoders that do produces playable xsub subtitles.


More information about the ffmpeg-devel mailing list