[FFmpeg-devel] [PATCH 0/2] Improved XSUB compatibility
Reimar.Doeffinger at gmx.de
Thu Nov 7 19:28:36 CET 2013
On Thu, Nov 07, 2013 at 11:37:03AM +0100, Erik Olofsson wrote:
> I wasn't sure how to attribute patches to fixes so I tried to attribute the
> whole patchset to the ticket.
> What about the following additions to the commit messages?
> Fixes actual problem in ticket 3031
> Fixes reported but not actual problem in ticket 3031
>From my point of view it doesn't really matter.
Just knowing that a patch is related to a certain ticket so
one knows where to look for additional information from "git log"
is what matters.
I would probably go with "Fixes ticket 3031" and/or "Related to ticket
3031" as generic phrases that always work.
> What does out xsub decoder do with the bounding box? Those two definitely
> > should match.
> > If the decoder already does +1 the patches look good, otherwise this needs
> > one more look.
> The coordinates of the lower right corner of the bounding box are actually
> redundant as the
> position and size of the text area are known.
> Most decoders, including FFMpeg, ignores this redundant information.
Ah yes, now I remember again. That patch looks good to me then.
I don't remember the API well enough to be sure about the other.
More information about the ffmpeg-devel