[FFmpeg-devel] [PATCH 2/2] avformat/astdec: return max score from probe after fixing probetest missdetections
Reimar.Doeffinger at gmx.de
Fri Nov 8 21:38:09 CET 2013
Michael Niedermayer <michaelni at gmx.at> wrote:
>On Thu, Nov 07, 2013 at 08:22:16AM +0100, Reimar Döffinger wrote:
>> On 06.11.2013, at 23:59, Michael Niedermayer <michaelni at gmx.at>
>> > Signed-off-by: Michael Niedermayer <michaelni at gmx.at>
>> > ---
>> > libavformat/astdec.c | 2 +-
>> > 1 file changed, 1 insertion(+), 1 deletion(-)
>> > diff --git a/libavformat/astdec.c b/libavformat/astdec.c
>> > index 12252dc..ddc685a 100644
>> > --- a/libavformat/astdec.c
>> > +++ b/libavformat/astdec.c
>> > @@ -35,7 +35,7 @@ static int ast_probe(AVProbeData *p)
>> > !AV_RB32(p->buf + 16) || AV_RB32(p->buf + 16) > 8*48000)
>> > return 1;
>> > - return AVPROBE_SCORE_MAX / 3 * 2;
>> > + return AVPROBE_SCORE_MAX;
>> Both look ok to me, though personally I feel max score is a bit high
>for the few things it checks...
>applied the first patch
>which score should the 2nd return ? anyone any suggestions ?
I don't have anything specific. If max feels right/good enough to you just go with it, don't let my rambling delay you.
I'd probably have looked around if any other format uses some reasonable value just below max, but to be honest I guess that is more a case of being overcautious than actually making sense.
More information about the ffmpeg-devel