[FFmpeg-devel] [PATCH] Add additional FFV1 fate tests

Peter B. pb at das-werkstatt.com
Sun Nov 10 23:16:48 CET 2013


On 11/10/2013 05:41 PM, Michael Niedermayer wrote:
> On Sun, Nov 10, 2013 at 04:52:28PM +0100, Peter B. wrote:
>> How is the default procedure for patch-improvements?
>> Should I post a patch for my patch - or rather one patch that applies as
>> one to git head?
> one patch on top of git head in this case

Clear.
I've attached the new patch.

Changes (compared to the previous version) include:
- Setting the word size for tiny_psnr to 8bits/16bits accordingly
- ${} replaced with $()
- Aligned "\" for multi-line statements


I'm still uncomfortable that the MAXDIFF ain't 0, which is caused by
re-using vsynth1 in different pix_fmts. A value >0 seems a bit confusing
for a lossless codec :)
However, as I understood it, the values calculated by tiny_psnr will be
constant in case of FFV1, so they'll match the ref-files and therefore
should be fine for testing. I'm planning to improve this situation by
generating dedicated 4-frame-testvideos for multiple pix_fmts and
resolutions on-the-fly (like vsynth) in the future.


Regards,
Pb

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-fate-Add-additional-FFV1-tests.patch
Type: text/x-patch
Size: 65304 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20131110/f8372cbf/attachment.bin>


More information about the ffmpeg-devel mailing list