[FFmpeg-devel] Patch for the ticket #3127 (Video stream publishing via RTMPT)

Valeriy Argunov hzdbyte at gmail.com
Fri Nov 15 05:30:20 CET 2013


The issue occurs because ffmpeg functions expect AVERROR_EOF when calling
ffurl_read, but it is never returned.
Please look at the comments on https://trac.ffmpeg.org/ticket/3127
15.11.2013 9:29 пользователь "Michael Niedermayer" <michaelni at gmx.at>
написал:

> On Thu, Nov 14, 2013 at 05:24:17PM +0700, Valeriy Argunov wrote:
> > Here is a patch that partially fixes https://trac.ffmpeg.org/ticket/3127
>
> >  avio.c |    2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 05a48480e9f6d7a68ff6c19d6129c2cd166605d4
>  0001-Partial-fix-for-the-ticket-3127-Video-stream-publish.patch
> > From 444ddcbc141f3160557db39514593b9b04ca39a2 Mon Sep 17 00:00:00 2001
> > From: Byte <hzdbyte at gmail.com>
> > Date: Thu, 14 Nov 2013 17:18:52 +0700
> > Subject: [PATCH] Partial fix for the ticket #3127 (Video stream
> publishing via
> >  RTMPT)
> >
> > ---
> >  libavformat/avio.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/libavformat/avio.c b/libavformat/avio.c
> > index 225d982..d7f1094 100644
> > --- a/libavformat/avio.c
> > +++ b/libavformat/avio.c
> > @@ -305,7 +305,7 @@ static inline int retry_transfer_wrapper(URLContext
> *h, uint8_t *buf,
> >                  av_usleep(1000);
> >              }
> >          } else if (ret < 1)
> > -            return (ret < 0 && ret != AVERROR_EOF) ? ret : len;
> > +            return (ret < 0) ? ret : len;
>
>
> I think this could be loosing data
> is it neccessary for the bugfix to also return EOF when data has
> already been read ?
> if not, maybe a check for that could be added
>
>
> also reimar and nicolas might have some comments ...
>
> thanks
>
> --
> Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
>
> I do not agree with what you have to say, but I'll defend to the death your
> right to say it. -- Voltaire
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
>


More information about the ffmpeg-devel mailing list