[FFmpeg-devel] h264: Do not treat the initial frame special in handling of frame gaps

[Clément Bœsch]

On Thu, Nov 14, 2013 at 02:45:24PM +0100, Joakim Plate wrote:
> Michael Niedermayer <git <at> videolan.org> writes:
> 
> >
> > ffmpeg | branch: master | Michael Niedermayer <michaelni <at> gmx.at> |
> Thu Nov 14 11:27:45 2013 +0100|
> > [9e5ef1c5c37208326c59d642e2dc7afd3f10b09b] | committer: Michael
> Niedermayer
> >
> > h264: Do not treat the initial frame special in handling of frame gaps
> >
> > The not handling of frame gaps has lead to the lack of a dummy reference
> > frame, which has lead to the failure of decode_slice_header() which has
> > lead to one SEI recovery message being skiped which had introduced a
> > slightly suboptimal recovery point for at least 1 h264 file compared to
> > JM.
> >
> > Found-by: Carl & BugMaster
> > Signed-off-by: Michael Niedermayer <michaelni <at> gmx.at>
> >
> 
> So we reintroduce the issues fixed in
> https://github.com/FFmpeg/FFmpeg/commit/babf4fe01a808327d53977ba319c113a930180b1?
> 
> Maybe those issues have been fixed in some other fashion? The point was
> after seeks the display was corrupt for a much longer time than it should
> have based on the recovery information.
> 

I might be taking Captain Obvious' hat but… why not add a few small set of
h264 regression tests for those issues? I saw a lot of recovery changes in
that code recently (as well as other changes). Coverage of h264 is mostly
good (~73% - http://coverage.ffmpeg.org/ffmpeg/libavcodec/index.html), but
those issues should be covered as well to avoid regressions IMO.

-- 
Clément B.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 490 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20131115/828aa74e/attachment.asc>