[FFmpeg-devel] [PATCH 1/7] vp9: use proper refcounting.

[Clément Bœsch]

On Mon, Nov 25, 2013 at 09:44:44PM -0500, Ronald S. Bultje wrote:
> Based on something similar in libav. Author is likely Anton Khirnov
> <anton at khirnov.net> but I'm not sure.
> ---
>  libavcodec/vp9.c | 92 +++++++++++++++++++++++---------------------------------
>  1 file changed, 38 insertions(+), 54 deletions(-)
> 
> diff --git a/libavcodec/vp9.c b/libavcodec/vp9.c
> index 785b187..28844b9 100644
> --- a/libavcodec/vp9.c
> +++ b/libavcodec/vp9.c
[...]
> -    // find unused reference
> -    for (i = 0; i < 10; i++)
> -        if (!s->fb[i]->data[0])
> -            break;
> -    av_assert0(i < 10);
> -    s->f = s->fb[i];
> +    s->f = frame;

So, you didn't answer me in the previous submission: In the original
patch, s->f was unreferenced just after this. Can you explain why it was
done as such, and/or what was wrong with it?

[...]

-- 
Clément B.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 490 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20131126/70ade3fd/attachment.asc>