[FFmpeg-devel] [PATCH] lavd/sdl: factorize overlay rect size in a separate function

Stefano Sabatini stefasab at gmail.com
Tue Nov 26 18:21:39 CET 2013

On date Monday 2013-11-25 13:47:34 +0100, Lukasz M encoded:
> On 25 November 2013 13:37, Stefano Sabatini <stefasab at gmail.com> wrote:
> > ---
> >  libavdevice/sdl.c | 84
> > ++++++++++++++++++++++++++++++++-----------------------
> >  1 file changed, 49 insertions(+), 35 deletions(-)
> Patch itself looks OK, but maybe we could create some common.c and common.h
> for code that is shared between devices.
> This computation will be sooner or later appear in other devices too, so
> maybe you can move generic code there and use it here.
> xv also allows to resize window, but original apect ratio is not kept. I
> was thinking about fixing it soon and probably could use it there.
> I'm not asking you to do it, but if you agree then give green ligth and
> I'll do it later.

OTOH the function is rather SDL specific (make use of SDL_Rect).
Patch pushed.
FFmpeg = Fundamental & Fabulous MultiPurpose Entertaining Governor

More information about the ffmpeg-devel mailing list