[FFmpeg-devel] [PATCH 3/3] ffmpeg: ensure that -fix_sub_duration doesnt create subtitles with zero duration

Michael Niedermayer michaelni at gmx.at
Sat Nov 30 05:14:09 CET 2013

On Thu, Nov 28, 2013 at 09:40:58PM +0100, Marton Balint wrote:
> On Mon, 25 Nov 2013, Nicolas George wrote:
> >Le tridi 3 frimaire, an CCXXII, Marton Balint a écrit :
> >>Yes, it is on purpose. As w4m pointed out in response to my earlier patch:
> >>
> >>https://lists.ffmpeg.org/pipermail/ffmpeg-devel/2013-November/thread.html#151037
> >>
> >>0 duration can also mean unknown (infinite) duration depending on
> >>the codecs used, so it would be wrong to drop them all.
> >>
> >>However, when fix_sub_duration is used, and the duration fixing code
> >>is generating 0 duration, that is definitely zero, and not undefined
> >>or infinite, so it is safe to drop it.
> >
> >Thanks for explaining. I suppose this patch is ok, then.
> >
> I have updated the patch descriptions based on the questions asked,
> and pushed them to my stable branch.
> Michael, could you please merge them? Nicolas sort of reviewed all three:
> 3e396ca ffmpeg: do not pass possibly undefined subtitles to sub2video_update
> 4d6f2ff ffmpeg: free empty subtitles as well in transcode_subtitles
> 31bb172 ffmpeg: ensure that -fix_sub_duration doesnt create subtitles with zero duration




Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

If you think the mosad wants you dead since a long time then you are either
wrong or dead since a long time.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20131130/03a1ade7/attachment.asc>

More information about the ffmpeg-devel mailing list