[FFmpeg-devel] [PATCH 3/6] dvbsubdec: always return the whole buffer as consumed bytes
cus at passwd.hu
Sun Oct 6 20:38:09 CEST 2013
On Sun, 6 Oct 2013, Reimar Döffinger wrote:
> On 06.10.2013, at 15:11, Marton Balint <cus at passwd.hu> wrote:
>> On Sat, 5 Oct 2013, Reimar Döffinger wrote:
>>> On Sat, Oct 05, 2013 at 07:34:55PM +0200, Marton Balint wrote:
>>>> We don't want leftover junk bytes to be accidentally feeded to us again.
>>> But is there any check that those are actually junk bytes?
>>> Shouldn't we in principle try to ensure they are?
>>> Or if we don't expect to encounter such warn?
>>> Possibly fail if strict is set?
>>> Just suggestions, based on me not particularly liking silently
>>> throwing away stuff that _could_ be relevant with no way at all for
>>> an application to detect that case...
>> You have a point, but I think adding a simple av_dlog in case of leftover bytes is enough. It can be done easily, and it would help the users to determine if something does go wrong and the leftover bytes aren't really junk. I will update the patch soon.
> Aren't av_dlog only compiled in when hacking the file to #define DEBUG?
> If you want users to be able to see it, a normal av_log at e.g. debug level seems better...
Yes, you're right, sorry. I will fix it and send the new patch.
More information about the ffmpeg-devel