[FFmpeg-devel] [PATCH 4/5] ogg: allow streams to update metadata

[wm4]

On Sat, 19 Oct 2013 09:40:45 -0400
Ben Boeckel <mathstuf at gmail.com> wrote:

> +    if (os->new_metadata) {
> +        uint8_t *side_data = av_packet_new_side_data(pkt,
> +                                                     AV_PKT_DATA_STRINGS_METADATA,
> +                                                     os->new_metadata_size);
> +        memcpy(side_data, os->new_metadata, os->new_metadata_size);
> +        av_free(os->new_metadata);
> +        os->new_metadata = NULL;
> +        os->new_metadata_size = 0;
> +    }
> +

I already told you somewhere else, but just for the ffmpeg-devel
public: I think this should introduce a new side data type.
AV_PKT_DATA_STRINGS_METADATA is intended to transfer AVFrame side
data from lavfi to decoder, while Ben's patch wants to update AVStream
metadata. (There's also the question whether side data is the proper
way to update AVStream metadata - IMO that's slightly hacky, but
there's probably no better way, so fine with me.)