[FFmpeg-devel] [PATCH 4/5] ogg: allow streams to update metadata
mathstuf at gmail.com
Sat Oct 26 04:08:35 CEST 2013
On Sat, Oct 19, 2013 at 22:43:27 +0200, Reimar Döffinger wrote:
> On 19.10.2013, at 15:40, Ben Boeckel <mathstuf at gmail.com> wrote:
> > + av_free(os->new_metadata);
> > + os->new_metadata = NULL;
> These (appearing in two places) can be merged into a single av_freep.
> > @@ -639,6 +646,7 @@ static int ogg_read_close(AVFormatContext *s)
> > ogg->streams[i].codec->cleanup(s, i);
> > }
> > av_free(ogg->streams[i].private);
> > + av_free(ogg->streams[i].new_metadata);
> > }
> > av_free(ogg->streams);
> Not really related to your patch, but I wonder why none of these use av_freep.
I guess because they're in an array and the array gets free'd below? The
ogg->streams free might make more sense with av_freep.
More information about the ffmpeg-devel