[FFmpeg-devel] [RFC]Improve adp detection

[Michael Niedermayer]

On Wed, Oct 30, 2013 at 01:14:38AM +0000, Carl Eugen Hoyos wrote:
> Michael Niedermayer <michaelni <at> gmx.at> writes:
> 
> > >      for (i = 0; i < p->buf_size - 3; i+=32)
> > >          if (p->buf[i] != p->buf[i+2] || p->buf[i+1] != p->buf[i+3])
> > >              return 0;
> > 
> > can these have any value ?
> 
> I wanted to ask the same question - I don't 
> understand the code in adpcm.c
> 
> > the decoder distinuishes only 4 cases for the 
> > upper 4 bits which would have 16 cases
> 
> Because of the "default:" case, I thought all 
> values are allowed.

if you print them for the files we have do some of these 4bit
values never occur ?



> 
> Carl Eugen
> 
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Freedom in capitalist society always remains about the same as it was in
ancient Greek republics: Freedom for slave owners. -- Vladimir Lenin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20131030/93134f16/attachment.asc>