[FFmpeg-devel] [PATCH]Show subtitle resolution in avcodec_string()

Michael Niedermayer michaelni at gmx.at
Tue Sep 3 16:19:21 CEST 2013


On Tue, Sep 03, 2013 at 04:02:06PM +0200, Nicolas George wrote:
> Le septidi 17 fructidor, an CCXXI, Carl Eugen Hoyos a écrit :
> > Hi!
> > 
> > Attached patch shows the user the problem with files like from ticket #679 or 
> > #2930.
> > 
> > Please comment, Carl Eugen
> 
> > diff --git a/libavcodec/utils.c b/libavcodec/utils.c
> > index 4e510e6..497cf15 100644
> > --- a/libavcodec/utils.c
> > +++ b/libavcodec/utils.c
> > @@ -2668,6 +2668,11 @@ void avcodec_string(char *buf, int buf_size, AVCodecContext *enc, int encode)
> >                           enc->time_base.num / g, enc->time_base.den / g);
> >          }
> >          break;
> > +    case AVMEDIA_TYPE_SUBTITLE:
> > +        if (enc->width)
> > +            snprintf(buf + strlen(buf), buf_size - strlen(buf),
> > +                     ", %dx%d", enc->width, enc->height);
> > +        break;
> >      default:
> >          return;
> >      }
> 
> I think this is a good idea, and I see no problem with the patch. But I do
> not maintain that file.

not the file but you maintain subtitles so if you say its good then
its good

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Breaking DRM is a little like attempting to break through a door even
though the window is wide open and the only thing in the house is a bunch
of things you dont want and which you would get tomorrow for free anyway
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20130903/96fe4753/attachment.asc>


More information about the ffmpeg-devel mailing list