[FFmpeg-devel] [PATCH] lavfi/drawtext: replace "draw" option with generic timeline interface.
eclipse7 at gmx.net
Tue Sep 3 23:59:01 CEST 2013
On 2013-09-03 21:22 +0200, Clément Bœsch wrote:
> On Fri, Aug 23, 2013 at 11:26:46PM +0200, Alexander Strasser wrote:
> > > Does that matter in practice?
> > Depends on your use-case I would say. If I would be using it today
> > and it breaks my application tomorrow or in a few weeks I would quite
> > certainly be annoyed!
> I applied a patch with proper deprecation, and code is currently working
> with both 'draw' and 'enable'. Result is a huge pile of #ifdefery but I'm
> going to blame you for this.
> Of course, you are free to flame me on cvslog.
Not sure if flaming is needed, but I sure never suggested adding
> > My point is: When you are a user of FFmpeg or lavfi you have lots
> > of other stuff to care about; not FFmpeg related at all. So every
> > disruption will make you increase a mental counter (those are famous
> > for not being really accurate/correct) for that component. So naturally
> > if FFmpeg has the highscore you will not be positive about it. This is
> > not made up, changing APIs and lacking docs are probably the number one
> > complaints expressed to me in person. Though that is another mental
> > counter and of course not representative in any way. I am just saying
> > this is not a purely theoretical debate.
> New version will print a warning for a while, pointing out what to change.
That should be helpful at least.
> > Anyway back the actual topic--- I do not see why this functionality
> > has to be removed. It is neither huge nor complex; might even be useful
> > to extend it in future. I might very well be overlooking something. Am
> > I missing something essential?
> Duplicated support, inconsistency (which confuse both users and developers
> since part of the interface), entangled with an already complex filter
> (aka not isolated at all), ...
I really can't follow you here, but since you replied after pushing
there is not much point in further discussion. I have said my opinion
and that I do not think there is a no complexity concern in this case.
I would have just additionally added timeline support like in the
tiny patch I sent.
Anyway thanks for adding timeline and caring about deprecation,
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 198 bytes
Desc: not available
More information about the ffmpeg-devel