[FFmpeg-devel] [PATCH] avfilter/vf_noise: remove special code for widths not multiple of 8

Michael Niedermayer michaelni at gmx.at
Thu Sep 12 17:35:03 CEST 2013


On Thu, Sep 12, 2013 at 03:28:33PM +0000, Paul B Mahol wrote:
> On 9/12/13, Michael Niedermayer <michaelni at gmx.at> wrote:
> > On Thu, Sep 12, 2013 at 01:41:56PM +0000, Paul B Mahol wrote:
> >> It is not required, as linesize should be aligned to 32.
> >>
> >> Signed-off-by: Paul B Mahol <onemda at gmail.com>
> >> ---
> >>  libavfilter/vf_noise.c | 21 ++++-----------------
> >>  1 file changed, 4 insertions(+), 17 deletions(-)
> >
> > breaks handling of images that have width % 8 != 0
> 
> Can you elaborate why you think it breaks when width % 8 != 0?

because it writes outside the width x height rectangle

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

it is not once nor twice but times without number that the same ideas make
their appearance in the world. -- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20130912/e840f63d/attachment.asc>


More information about the ffmpeg-devel mailing list