[FFmpeg-devel] [PATCH] lavc: Don't export?ff_vdpau_vc1_decode_picture

Thilo Borgmann thilo.borgmann at mail.de
Tue Sep 17 16:37:47 CEST 2013


Am 17.09.13 16:22, schrieb Stefano Sabatini:
> On date Tuesday 2013-09-17 14:10:18 +0000, Carl Eugen Hoyos encoded:
>> Derek Buitenhuis <derek.buitenhuis <at> gmail.com> writes:
>>
>>> We only export it because XBMC was using stuff in an 
>>> unsupported and awful way, and we should *not* add hacks 
>>> in for ever downstream project that uses our libs in 
>>> fucked up ways.
>>
>> Thank you for explaining!
>> I think we should support downstream no matter how stupid 
>> they are as long as it does not hurt.
>> After all, downstream is what a library is about imo.
> 
> OTOH I agree with the sentiment, we should avoid to clutter the
> library with application specific hacks. Keeping them, instead of
> replacing them with proper solutions, does no good to the user nor to
> the library especially when it is not clear what the problem addressed
> by the hack is.

I think we should not remove such 'hacks' as long as there is no proper solution
for the downstream projects.
To get rid of these, nothing holds us back from discussion with - in that case
XBMC - to solve the issue instead of just removing them silently and break other
projects.

However, adding new hacks instead should be avoided - I wonder how these came in
anyway.

-Thilo



More information about the ffmpeg-devel mailing list