[FFmpeg-devel] [PATCH] remove libmpcodecs

Paul B Mahol onemda at gmail.com
Wed Sep 18 19:23:50 CEST 2013


On 9/18/13, Stefano Sabatini <stefasab at gmail.com> wrote:
> On date Tuesday 2013-09-17 18:46:49 +0000, Paul B Mahol encoded:
>> Signed-off-by: Paul B Mahol <onemda at gmail.com>
>> ---
>>  LICENSE                                    |    2 -
>>  configure                                  |    1 -
>>  doc/filters.texi                           |   48 -
>>  libavfilter/Makefile                       |   18 -
>>  libavfilter/allfilters.c                   |    1 -
>>  libavfilter/libmpcodecs/av_helpers.h       |   27 -
>>  libavfilter/libmpcodecs/cpudetect.h        |   60 -
>>  libavfilter/libmpcodecs/img_format.c       |  233 ---
>>  libavfilter/libmpcodecs/img_format.h       |  300 ----
>>  libavfilter/libmpcodecs/libvo/fastmemcpy.h |   99 --
>>  libavfilter/libmpcodecs/libvo/video_out.h  |  281 ----
>>  libavfilter/libmpcodecs/mp_image.c         |  253 ----
>>  libavfilter/libmpcodecs/mp_image.h         |  159 ---
>>  libavfilter/libmpcodecs/mp_msg.h           |  166 ---
>>  libavfilter/libmpcodecs/mpc_info.h         |   43 -
>>  libavfilter/libmpcodecs/pullup.c           |  823 -----------
>>  libavfilter/libmpcodecs/pullup.h           |  102 --
>>  libavfilter/libmpcodecs/vf.h               |  169 ---
>>  libavfilter/libmpcodecs/vf_eq.c            |  240 ----
>>  libavfilter/libmpcodecs/vf_eq2.c           |  519 -------
>>  libavfilter/libmpcodecs/vf_fspp.c          | 2118
>> ----------------------------
>>  libavfilter/libmpcodecs/vf_ilpack.c        |  458 ------
>>  libavfilter/libmpcodecs/vf_pp7.c           |  491 -------
>>  libavfilter/libmpcodecs/vf_pullup.c        |  316 -----
>>  libavfilter/libmpcodecs/vf_qp.c            |  178 ---
>>  libavfilter/libmpcodecs/vf_softpulldown.c  |  163 ---
>>  libavfilter/libmpcodecs/vf_uspp.c          |  393 ------
>>  libavfilter/libmpcodecs/vfcap.h            |   56 -
>>  libavfilter/version.h                      |    2 +-
>>  libavfilter/vf_mp.c                        |  795 -----------
>>  30 files changed, 1 insertion(+), 8513 deletions(-)
> [...]
>
> So these are left:
>        eq2
>        eq
>        fspp
>        ilpack
>        pp7
>        pullup
>        qp
>        softpulldown
>        uspp
>
> pullup can be removed just now I thinks, remaining bugs could be
> fixed in the native filter.
>
> eq and eq2 look useful and should be ported (or merged in hue), maybe
> we already have some patches for that?
>
> fspp, pp7, uspp removals were discussed some time ago and we have
> people/users still wanting them, but I'm not sure we have some people
> wanting to work on their port. If we port them, having an howto with
> comparations of the various postprocessing options in the manual or in
> the wiki would be really helpful.
>
> As for qp, ilpack, and softpulldown I can't really say, but I'm
> willing to keep the wrapper unless we port all the remaining filters
> unless there are strong reasons not to keep them (not useful, not
> relevant, or completely broken by design).

qp is broken - it does nothing.
softpulldown was broken too, but I was (very for Carl) stupid and added
hack to wrapper.
ilpack - wtf is that?

>
> I know that removing large chunks of code can be relieving, OTOH
> keeping and maintaining the code as is should not cause much trouble
> so it should be kept.

Nobody maintains that code, mainly because for easy (copy/paste) changes
that come from mplayer.

>
> I remember that when we removed vhook many complained for the missing
> features with no ready replacement, nor people who complained lent any
> help to implement the missing features, so that was not useful not
> even for the developers implementing them.

You are mixing apples and oranges here. Did any user (except Michael)
wanted libmpcodecs merge?

>From my experience most user that use mplayer filters are actually
using mencoder. And there are not many of such users.

>
> If the current code disturbs you just let it be, do not compile it,
> resist the urge to look at it, pretend it doesn't exist, and no harm
> shall be done to you.

No, i will not pretend it does not exist. It can not harm me in any way.

I will enjoy in every single commit that removes some bit of it.


More information about the ffmpeg-devel mailing list