[FFmpeg-devel] [PATCH] lavf: add SFTP protocol via libssh
derek.buitenhuis at gmail.com
Fri Sep 20 14:17:47 CEST 2013
On 9/19/2013 5:58 PM, James Almer wrote:
>> fcntl.h is not portable. Use the proper guards provided in config.h
> There's no configure check for fcntl.h, only for fcntl().
> Every file i could find that included that header did it without guards.
Indeed you are correct, woops.
>>> +#define D AV_OPT_FLAG_DECODING_PARAM
>>> +#define E AV_OPT_FLAG_ENCODING_PARAM
>> D and E are far to short and potentially pollute and conflict
>> with the namespacing of system headers.
> options_table.h defines E and D the same way, so i don't think it will
> be a problem.
Meh. I don't particularly think it's a good idea, but OK.
More information about the ffmpeg-devel