[FFmpeg-devel] [PATCH] x86/synth_filter: remove the main loop when it's not needed
jamrial at gmail.com
Fri Apr 4 19:06:17 CEST 2014
On 04/04/14 5:45 AM, Christophe Gisquet wrote:
> 2014-04-04 7:56 GMT+02:00 James Almer <jamrial at gmail.com>:
>> +%if ARCH_X86_32 || mmsize == 16
> Although a contrived example, imagine ARCH_X86_64 && mmsize == 8. It
> absolutely can't exist at the moment unless a benign editing error
> occurs later on.
Or someone goes and adds a 3dnow version :P
> But what I mean is it should read "mmsize < 32" instead of "mmsize ==
> 16". Furthermore, this corresponds to the reason, that 16 regs holding
> at least 256b allow removing the loop.
> I can't edit it at the moment so, although I'm the culprit, can you do
> this in my stead please if you deem it worth?
You're not the culprit. You originally wrote it as notcpuflag(avx) but i
changed it in preparation for an xmm fma4 patch I'll send later.
What matters after all is the register size and not the fact avx is
Will send an updated patch in a moment. Thanks
More information about the ffmpeg-devel