[FFmpeg-devel] [PATCH]Only expect prores packet offset in mkv if the specified codec id was set

[Michael Niedermayer]

On Sun, Apr 06, 2014 at 12:47:52AM +0000, Carl Eugen Hoyos wrote:
> Michael Niedermayer <michaelni <at> gmx.at> writes:
> 
> > > Attached patch will be necessary to support decoding 
> > > broken prores-in-mkv.
> 
> Sorry if this was unclear:
> The patch is necessary to decode currently unsupported 
> prores-mkv-files (which believe that mov code points == 
> fourcc), it is not sufficient though: Either searching 
> for code points if nothing was found in the fourcc list 
> or the hacky solution of adding prores to riff.c is 
> also needed.
> 
> > > Please comment, Carl Eugen
> > 
> > where can i find such a file ?
> 
> The Haali mkv file in:
> http://samples.ffmpeg.org/ffmpeg-bugs/trac/ticket3434/

i think its better to check if the icpf chunk header is in there
and add it if its not instead of making that depenant from the
codec string id
also theres a second prores check  in there

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Those who are too smart to engage in politics are punished by being
governed by those who are dumber. -- Plato 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20140407/c8e6d913/attachment.asc>