[FFmpeg-devel] [PATCH] flac demuxer: improve seeking

[Michael Niedermayer]

On Sun, Apr 13, 2014 at 06:42:46PM +0000, Rainer Hochecker wrote:
> Michael Niedermayer <michaelni <at> gmx.at> writes:
> 
> > 
> > the seek aims at time -1, and previously seeks to 0, which i guess
> > is the first packet
> > after the patch the seek goes to 0.026122 at filepos 8870, which
> > does not look like the first packet
> > 
> > [...]
> 
> I send an update to github
> https://github.com/FFmpeg/FFmpeg/pull/64
> 
> The results are almost identical to original fate test.

why only almost ?
is there a bug in the original?

we had more than one user ask for exact seeking (not related to flac)
so iam a bit reluctant to worsen any seek functionality

also iam not sure calling av_read_frame() from read_timestamp() is a
good idea. av_read_frame() is a quite big function with lots of stuff
in it and the functions it calls
Iam not saying its wrong, just doesnt look very pretty and probably
makes understaning and debuging the code harder  ...


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

He who knows, does not speak. He who speaks, does not know. -- Lao Tsu
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20140413/68b71211/attachment.asc>