[FFmpeg-devel] [PATCH 1/2] lavu: add thread message API.

[Nicolas George]

Le sextidi 6 ventôse, an CCXXII, Clément Bœsch a écrit :
> double include it seems.

Fixed.

> Also, I think pthread.h include should be conditional.

Fixed.

> This might not compile without pthread

Fixed.

> Code in ffmpeg.c seems to rely on HAVE_PTHREADS; is this fine?

I assume the w32-pthread compat code will take care of that. If someone
could test on windows, that would be nice.

> so without thread, this will return ENOSYS; won't that cause problems with
> your new loop in ffmpeg.c?

You mean if a ffmpeg compiled with threads is used with a lavu compiled
without? Do we support that setup?

> You should not have this include here since the prototypes do not depend
> on pthread specific code; if you did, it would have mean that the code can
> not compile without threading.

Fixed.

New patch attached, no change on the second one except rebasing. FATE passes
on Debian both with and without threads.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-lavu-add-thread-message-API.patch
Type: text/x-diff
Size: 10566 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20140417/2714870f/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20140417/2714870f/attachment.asc>