[FFmpeg-devel] [PATCH] Add a gamma flag to exr loader to avoid banding
Reimar.Doeffinger at gmx.de
Mon Apr 28 21:19:07 CEST 2014
On 28.04.2014, at 19:59, Michael Niedermayer <michaelni at gmx.at> wrote:
> On Mon, Apr 28, 2014 at 11:43:16AM -0300, Gonzalo Garramuno wrote:
>> Ping. Just checking if the patch will be (pretty please) accepted or not.
> First it seems to still have a bug
> it fails fate
> --- ./tests/ref/fate/exr-slice-raw 2014-04-28 04:14:37.849375679 +0200
> +++ tests/data/fate/exr-slice-raw 2014-04-28 19:50:27.430558597 +0200
> @@ -1,2 +1,2 @@
> #tb 0: 1/25
> -0, 0, 0, 1, 3169800, 0x6a356d0d
> +0, 0, 0, 1, 3169800, 0x2cfefd25
> Second, some people seem to dislike it, and some (me and you at least)
> seem to think its ok until full float pixel format support
I will not object to it, but some considerations:
1) I think we agree that is a bad hack for something that could and should be fixed properly.
2) There is a balance between accepting hacks out of pragmatism vs. ending up encouraging people to write hacks instead of good solutions (note in particular that I believe this issue is basically the result of someone else having chosen the easier way, thus one hack resulting in the next).
3) It adds an option that people might rely on but which might be incompatible/require more hacks to support in a better solution. I would suggest marking the option as experimental/unsupported in the meaning we may remove it at any time with only a minor version bump.
More information about the ffmpeg-devel