[FFmpeg-devel] [PATCH] tests: Download lena.pnm if its missing from the source tree
u at pkh.me
Thu Aug 28 17:53:55 CEST 2014
On Thu, Aug 28, 2014 at 02:12:14PM +0200, Andreas Cadhalpun wrote:
> On 28.08.2014 14:01, Carl Eugen Hoyos wrote:
> >Andreas Cadhalpun <andreas.cadhalpun <at> googlemail.com> writes:
> >>But I'm fine with moving lena.pnm to the FATE samples,
> >>which are downloaded with 'make fate-rsync'.
> >>Attached patch removes tests/lena.pnm and adapts the
> >>tests, assuming lena.pnm would be added to the top-level
> >>of the SAMPLES directory.
> >As said, imo lena should be copied from either SAMPLES
> >or tests/ to tests/data and used from there. This
> >allows us to keep a very useful testfile in git master.
> If it's made sure that lena.pnm doesn't end up in the distributed tarball,
> it could stay in git master as test file (although I'd find it better to use
> a free test file there).
> But I'm not sure what copying it to tests/data would be good for?
> The tests still could only be run if SAMPLES is present, or they would fail
> in the distributed tarball.
File size and dimensions are the same, and we can of course keep the file
name since the person looks like Lena a bit.
Would that one be OK?
According to http://goo.gl/0K3qyP it should be OK as long as the
attribution is kept, which can be done in the commit message.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 473 bytes
Desc: not available
More information about the ffmpeg-devel