[FFmpeg-devel] [RFC] [PATCH] proresenc_kostya: warn/reject on incorrect profile

Michael Niedermayer michaelni at gmx.at
Sat Aug 30 14:26:26 CEST 2014


On Sat, Aug 30, 2014 at 01:13:56PM +0200, Christophe Gisquet wrote:
> Hi,
> 
> 2014-08-24 18:56 GMT+02:00 Michael Niedermayer <michaelni at gmx.at>:
> > aggree, a PRORES_PROFILE_AUTO seems like a good idea
> > with it mismatching profile and pixel format can be errors while
> > by default the profile can be selected based on the pixel format
> 
> The attached patch makes it selects either 4444 or HQ profile
> depending on whether there's an alpha channel. If a profile is
> selected that does not have alpha but the input data has alpha, it
> warns that it will not encode it.
> 
> Best regards,
> -- 
> Christophe

>  proresenc_kostya.c |   21 +++++++++++++++++++--
>  1 file changed, 19 insertions(+), 2 deletions(-)
> cf627c08cf26aa889a17ded6b3e9684115eec296  0001-proresenc_ks-allow-auto-selecting-profile.patch
> From 0b134da9eba4f6f08422d22a1a0428f564fe8f11 Mon Sep 17 00:00:00 2001
> From: Christophe Gisquet <christophe.gisquet at gmail.com>
> Date: Mon, 18 Aug 2014 11:27:50 +0200
> Subject: [PATCH] proresenc_ks: allow auto-selecting profile
> 
> The user may not know how to select the profile, nor what he needs, in
> particular to encode alpha.
> 
> Therefore, use an automatic selection as default, and warn when the
> manually selected profile may cause issues.

applied

thanks

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

During times of universal deceit, telling the truth becomes a
revolutionary act. -- George Orwell
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20140830/0351b178/attachment.asc>


More information about the ffmpeg-devel mailing list