[FFmpeg-devel] [PATCH] lavf/oggenc: use meaningful error codes

Michael Niedermayer michaelni at gmx.at
Wed Dec 3 01:10:21 CET 2014


On Wed, Dec 03, 2014 at 12:36:23AM +0100, Lukasz Marek wrote:
> Signed-off-by: Lukasz Marek <lukasz.m.luki2 at gmail.com>
> ---
>  libavformat/oggenc.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)

LGTM

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Its not that you shouldnt use gotos but rather that you should write
readable code and code with gotos often but not always is less readable
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20141203/a58ad993/attachment.asc>


More information about the ffmpeg-devel mailing list